Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.7.0: files and resources show up as "unrouted" in generated traces #819

Closed
hlship opened this issue Mar 2, 2024 · 0 comments · Fixed by #829
Closed

0.7.0: files and resources show up as "unrouted" in generated traces #819

hlship opened this issue Mar 2, 2024 · 0 comments · Fixed by #829
Assignees
Labels
Milestone

Comments

@hlship
Copy link
Contributor

hlship commented Mar 2, 2024

The new telemetry support largely works well, but while experimenting, I found that trace data is missing for any response that is not generated due to routing; this include the resource and file interceptors, and perhaps others.

We should find a way for such interceptor to communicate (via a context key) that they generated a response, even if it wasn't routed, that can be used by the request tracing interceptor to generate a reasonable name for the trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant