fix: Fix error where a lot of domains were not detected #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: - `niteroi.br / *.nom.br` - Change trie from `niteroinom>*` to `niteroi,nom>*` - `police.uk / *.sch.uk` - Change trie from `policesch>*` to `police,sch>*` - `budejju.no / nes.buskerud.no` - Change trie from `budejjubuskerud>nes` to `budejju,buskerud>nes` - `hønefoss.no / os.hordaland.no` - Change trie from `hønefosshordaland>os` to `hønefoss,hordaland>os` - `molde.no / heroy.more-og-romsdal.no` - Change trie from `moldemore-og-romsdal>heroy` to `molde,more-og-romsdal>heroy` - `nordkapp.no / bo.nordland.no` - Change trie from `nordkappnordland>bo` to `nordkapp,nordland>bo` - `osterøy.no / valer.ostfold.no` - Change trie from `osterøyostfold>valer` to `osterøy,ostfold>valer` - `tananger.no / bo.telemark.no` - Change trie from `tanangertelemark>bo` to `tananger,telemark>bo` - `vestby.no / sande.vestfold.no` - Change trie from `vestbyvestfold>sande` to `vestby,vestfold>sande` - `haugesund.no / os.hedmark.no` - Change trie from `haugesundhedmark>os` to `haugesund,hedmark>os`
|
Fixes #64 |
|
It's a lot more than just the ones that are listed there. Notably this fixes s3.amazonaws.com too. |
|
Thanks for your PR and feedback. I'll review it the next days. |
|
Hey @jhnns - can you please merge and release these changes? |
|
@jhnns bump, this would be great to see fixed |
jhnns
reviewed
May 27, 2019
| if (indexOfDifference === -1) { | ||
| // Identical lines | ||
| return ""; | ||
| } | ||
| if (indexOfDifference === 0) { | ||
| // line and prevLine are completely different | ||
| separatorFromPrev = SEPARATORS.RESET; | ||
| } else if (prevLine.length === line.length && indexOfDifference === line.length - 1) { | ||
| } else if (prevLine.length <= line.length && indexOfDifference === prevLine.length - 1) { |
There was a problem hiding this comment.
I think the whole length check is not necessary or too strict. We should just compare indexOfDifference === prevLine.length - 1)
jhnns
changed the title
|
Awesome 🎉 🎉 🎉 thank you so much for this PR. This fixes a lot of domains. |
jhnns
added a commit
that referenced
this pull request
May 27, 2019
|
Published with |
jhnns
added a commit
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of domains were not recognised, due to issues with the separator logic in the trie serializer.
TLDs which didn't work, but now do, are as follows:
niteroi.br / *.nom.br
Changes trie snapshot from
niteroinom>*toniteroi,nom>*police.uk / *.sch.uk
Changes trie snapshot from
policesch>*topolice,sch>*budejju.no / nes.buskerud.no
Changes trie snapshot from
budejjubuskerud>nestobudejju,buskerud>neshønefoss.no / os.hordaland.no
Changes trie snapshot from
hønefosshordaland>ostohønefoss,hordaland>osmolde.no / heroy.more-og-romsdal.no
Changes trie snapshot from
moldemore-og-romsdal>heroytomolde,more-og-romsdal>heroynordkapp.no / bo.nordland.no
Changes trie snapshot from
nordkappnordland>botonordkapp,nordland>boosterøy.no / valer.ostfold.no
Changes trie snapshot from
osterøyostfold>valertoosterøy,ostfold>valertananger.no / bo.telemark.no
Changes trie snapshot from
tanangertelemark>bototananger,telemark>bovestby.no / sande.vestfold.no
Changes trie snapshot from
vestbyvestfold>sandetovestby,vestfold>sandehaugesund.no / os.hedmark.no
Changes trie snapshot from
haugesundhedmark>ostohaugesund,hedmark>os