-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases 2.0 #927
base: master
Are you sure you want to change the base?
Releases 2.0 #927
Conversation
refactoring supports
Features/ NodeJS support
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am excited, good job! Didn't try it out yet, but inspected your changes. It's nice to have full TypeScript support 🤘.
prettified-message: > | ||
I have adjusted the formatting of this pull request for you. | ||
|
||
To stop seeing this message, please install Prettier on your machine and run | ||
`meteor npm run format` to format your changes before submitting them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this message should be updated (not using meteor
or having a script called format
).
.prettierignore
Outdated
@@ -0,0 +1,2 @@ | |||
node_modules/ | |||
*.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not format HTML files?
I've been testing the latest
Neither of these are ideal. I'm not familiar with the specifics of the IIFE wrapper or the specific differences between the way all three of your builds are targeted, but I've never run into an issue like this before. |
wrtc doesn’t work on Apple Silicon. See node-webrtc/node-webrtc#698
Sorry, just copy&paste it from CHANGELOG because I want to sync it.
V2
The main goals of the second version:
es6
and latest tools;Breaking changes
Drop ES5 supports
If you need to support es5, you can recompile the lib from the sources or use the latest version from the v1 branch like
npm i peerjs@1
.Remove
webrtc-adapter
package fromdependencies
The modern browsers mostly works good without any additional libs like webrtc-adapter.
You can increase cross browsers support by manually add
webrtc-adapter
package to your project:npm install webrtc-adapter
Then import it as soon as possible. For example, you have an entry point for your application in the file
index.tsx
. So, lets add the import:See more: https://github.com/webrtcHacks/adapter
Remove browser detection features from the library.
The
browser
field was removed from theutil
classand the
OFFER
packet.The
main
field ofpackage.json
now points to the non minified version.Today, most projects use bundlers with a minification step. Sometimes, double minification can lead to issues.
If you want to use the minified version, use it directly from the
dist
folder like:Use
ESBuild
as bundler.Parcel 1 was a good choice years ago, but now esbuild seems like simple and good solution!
Another changes
devDependencies
Prettier
for the code style