Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences From graphql-dotnet/server #21

Open
RehanSaeed opened this issue Jan 11, 2019 · 8 comments
Open

Differences From graphql-dotnet/server #21

RehanSaeed opened this issue Jan 11, 2019 · 8 comments

Comments

@RehanSaeed
Copy link

@pekkah Just saw your comment on graphql-dotnet/server#193. What are the main reasons for forking the code and starting again? I see the addition of Signal-R as being super valuable because it has a backplane already implemented, there is an open issue in graphql-dotnet/server to implement that. It also seems to be schema first which I think is the direction that people are going.

Also, what is the quality of this project, alpha, beta?

@RehanSaeed
Copy link
Author

Oh and finally, what features are missing as compared to graphql-dotnet/server but also apollo server.

@pekkah
Copy link
Owner

pekkah commented Jan 11, 2019

Note that this is not a fork and was started from scratch because I wanted something simple without legacy pressure. First it was just a experiment to understand the graphql spec more closely but quickly became whole project of its own. It's not meant to compete with graphql-dotnet. I'm also trying to keep it more as an library instead of offering everything out of the box. I make no guarantees on backwards compatibility at least until version 1.0.

@RehanSaeed
Copy link
Author

Writing the schema in .gql files seems to be the way the community has gone down and actually recommends. Unfortunately, graphql-dotnet doesn't seem to have that support. Having the schema, has some other advantages, in that you get VS-Code Apollo extension support etc. too, along with their GitHub bot to check for breaking changes. Also, it would be easier for people to learn because it aligns much more closely with other GraphQL implementations.

Could the learnings from this project, specifically the Signal-R bits and schema first approach be applied to graphql-dotnet?

It's certainly interesting and something I'll keep an eye on.

@joemcbride
Copy link

Writing the schema in .gql files seems to be the way the community has gone down and actually recommends. Unfortunately, graphql-dotnet doesn't seem to have that support.

It does, it was added in 2.0. See “Schema First Approach” in the introduction. https://graphql-dotnet.github.io/docs/getting-started/introduction

@RehanSaeed
Copy link
Author

I forgot that existed! I suppose I forgot because it's not clear to me how to use the schema first approach using the ASP.NET Core server bits. If I get some time, I'll see if I can investigate.

@thangchung
Copy link

@joemcbride I have never known after read this issue. Thank you for your clarify 👍

@pekkah
Copy link
Owner

pekkah commented Apr 18, 2019

To see the differences in action go to https://github.com/pekkah/tanka-graphql-samples

  • schema stitching/splitting /manipulation
  • jwt based authentication
    Etc.

@pekkah
Copy link
Owner

pekkah commented Apr 3, 2020

One new feature coming up in 2.0.0 is a new parser using Span which improves the performance by both being faster and allocating less. It's compatible with current GraphQL draft specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants