Use 'hotfix' for parser performance issue #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A performance issue in the Pelias Parser where certain inputs can cause long parse times and out of memory errors was [recently reported](#1530). This change implements a short term fix by disabling some functionality around unit number parsing that was contributing to the issue. From our analysis it's not so much that the unit number parsing _caused_ the issue, but it was the most recently added functionality that contributed to it. While we develop a longer term fix, which should allow us to keep unit number parsing around, this "hotfix" will keep everything running smoothly. Unit numbers are not yet fully supported by Pelias so there _shouldn't_ be any major loss in functionality. Fixes #1530
orangejulius
added a commit
that referenced
this pull request
Nov 29, 2021
Historically we've kept most Pelias NPM dependencies on carat versions, but because the Pelias Parser can cause changes in acceptance-test results for any change (minor or even bug fix), we've kept it pinned to a specific version so we can explicitly upgrade. Recently, we were on a [hotfix branch](#1531) of the parser, but while switching back to using a version specification, we switched to [using a carat range](#1565). While manually bumping the version on a frequent basis is a bit annoying, it helps avoid any chance that unexpected or untested parser changes will find their way into the API releases, so this change brings us back to a pin of the current latest version of the Pelias Parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A performance issue in the Pelias Parser where certain inputs can cause long parse times and out of memory errors was recently reported.
This change implements a short term fix by disabling some functionality around unit number parsing that was contributing to the issue. From our analysis it's not so much that the unit number parsing caused the issue, but it was the most recently added functionality that contributed to it.
While we develop a longer term fix, which should allow us to keep unit number parsing around, this "hotfix" will keep everything running smoothly. Unit numbers are not yet fully supported by Pelias so there shouldn't be any major loss in functionality.
Fixes #1530