Upgrade pelias-parser to v2.0.0 #1565
Conversation
|
Excellent. To be honest I think we can save everyone some trouble and not mark this as a breaking change. Unit number parsing has been removed in the API for some time, and even before then I'm pretty sure the queries in API didn't take advantage of any unit number that was found when parsing. |
|
What testing do you think we should do before releasing this? The unit number removal is, of course, well tested at this point, but I'd be interested to see the impact of other changes (hopefully there are improvements!) |
Changes in pelias/parser being brought in: - pelias/parser@72d6463 - pelias/parser@90481c5 - pelias/parser@94eae1b - pelias/parser@e92f96c - pelias/parser@a1af69b Original commit to pin pelias-parser to a branch: 4061a2f
missinglink
force-pushed
the
parser_dep_upgrade
branch
from
5a393fd
to
79d3775
Compare
orangejulius
changed the title
|
We've tested this out extensively across all our test suites and there are no major regressions. (We've catalogued the two small ones we found in pelias/parser#151 and pelias/parser#152). There are probably quite a few improvements to parsing in the Netherlands especially, I think we'll be following up more closely on that. |
Historically we've kept most Pelias NPM dependencies on carat versions, but because the Pelias Parser can cause changes in acceptance-test results for any change (minor or even bug fix), we've kept it pinned to a specific version so we can explicitly upgrade. Recently, we were on a [hotfix branch](#1531) of the parser, but while switching back to using a version specification, we switched to [using a carat range](#1565). While manually bumping the version on a frequent basis is a bit annoying, it helps avoid any chance that unexpected or untested parser changes will find their way into the API releases, so this change brings us back to a pin of the current latest version of the Pelias Parser.
As discussed in #1550, this PR takes us off a branch of
pelias-parserand gets us back on the latest published version.Noteworthy changes from pelias/parser being brought in:
Original commit to pin pelias-parser to a branch: 4061a2f
closes #1550