Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to dependencies #1566

Closed
wants to merge 2 commits into from
Closed

Conversation

Joxit
Copy link
Member

@Joxit Joxit commented Oct 6, 2021

I noticed that dependencies were often seen as countries, but it is not possible to use the boundary.country parameter to filter searches for documents that are located in dependencies.

Now the view boundary_country uses a multi_match query to match both country_a and dependency_a.

npm install is failing because the branch pelias/parser#remove-unit-type does not exists. So I sync my branch with origin/parser-remove-unit-type-updated

needs pelias/query#129

@missinglink
Copy link
Member

FYI: the pelias/parser branching issue should be resolved shortly in #1565

Copy link
Member

@missinglink missinglink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See approval comments in pelias/query#129

@Joxit
Copy link
Member Author

Joxit commented Oct 7, 2021

Superseded by pelias/query#129

@Joxit Joxit closed this Oct 7, 2021
@Joxit Joxit deleted the joxit/feat/boundary.country branch October 7, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants