Display full response body on error #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compare app has always had fairly cryptic messaging when there was
an error response from one of the Pelias servers.
It ignores any actual response content from Pelias, and instead displays
an error message ('failed to load json') as well as a bit of static,
synthesized JSON. Neither of these contain much information at all.
This PR changes around the behavior so that in the case of any
error-like response (really, a response that does not have the
`geocoding` section that Pelias generally returns), the actual response
body is displayed, which might help debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compare app has always had fairly cryptic messaging when there was an error response from one of the Pelias servers.
It ignores any actual response content from Pelias, and instead displays a static error message ('failed to load json') as well as a bit of synthesized JSON. Neither of these contain much information at all.
Before
This PR changes around the behavior so that in the case of any error-like response (really, a response that does not have the
geocodingsection that Pelias generally returns), the actual response body is displayed, which might help debugging.After
