Examples of correct addresses in NL

[emacgillavry]

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.

---

Here's the reason for this change 🚀

We'd like to contribute changes and additions to the resources to be able to validate correct addresses.

---

Here's what actually got changed 👏

• Add address with a "St" is recognised as a personal_suffix, not as a personal_title
• "Korte" is recognised as a personal title, but is merely an adjective (korte = short) Adjective 'Korte' is incorrectly recognised as a personal title in NL addresses #129
• Typo in 'BurgeRmeester' prevents 'Burgemeester' from being recognised as a personal suffix Typo in 'BurgeRmeester' as personal title for NL addresses #130
• Groenendaal and Clarenburg have latter parts as street_types, not being thoroughfares (-daal = dale, -burg = borough) Streetnames ending in -'burg', -'daal' not recognised #131
• Structuurbaan, Agorabaan, Furkabaan (-baan = avenue) Streetnames ending in -'baan' not recognised #133
• Rembrandtplein has latter part as street_type (-plein* = place) Street type '-plein' not recognised in Netherlands addresses #128
• Postcode without space Recognise 6-position postcodes in addresses in the Netherlands (without spaces) #127
• Directional suffix abbreviated "O.Z." Recognise 'westzijde', 'WZ' as directionals in streetnames. #137
• Directional suffix fully written out Recognise 'westzijde', 'WZ' as directionals in streetnames. #137

---

Here's how others can test the changes 👀

All examples fail, hence we removed the 'test' pre-commit hook to be able to create a PR as a placeholder.

Fixes #127
Fixes #128
Fixes #129
Fixes #130
Fixes #131
Fixes #133
Fixes #137

[Joxit]

Hi @emacgillavry thank you for your PR
Can you rebase your code to master ? We need to trigger the CI again with GitHub Actions 😄

[emacgillavry]

Did a rebase, but not too familiar with this workflow. Hope this works out ok. Otherwise, don't hesitate to reach me on gitter/pelias.

[missinglink]

hi @emacgillavry, this is looking great, I see you've checked all the items off your list 👍

@Joxit there is an issue with GH Actions where it doesn't run Actions for contributors outside the org.
I can see why they set it up like that, to prevent abuse, but it's actually pretty annoying.

This is what it's currently set at for this repo:

I tried this in the past with another repo and even after changing that and asking the contributor to push an empty commit, it still didn't trigger the Actions, so I ended up having to move the commits to another branch manually.

I'd like to fix this so that all public contributions trigger Actions, especially since the repos are open-source so we don't pay anything, let me know if you figure it out. 🤷

see: https://docs.github.com/en/github/administering-a-repository/managing-repository-settings/disabling-or-limiting-github-actions-for-a-repository#configuring-required-approval-for-workflows-from-public-forks

[missinglink]

Adding my 'Approval' in attempt to trigger GH Actions.

note: please don't consider this an endorsement/approval of the work at this time.

[missinglink]

I don't see this option:

The org settings are the same BTW:

dismissing review, did not trigger Actions

[Joxit]

Oh, thank you @missinglink for the intel, that's sad 😞

I saw one error with the rebase, so I will try to fix this with @emacgillavry and do my review

[missinglink]

Oh look, it's working 🪄

[Joxit]

Thank you again @emacgillavry for your great contribution and your time 😄

[missinglink]

Late to the party on this one, couple minor comments.

Really great stuff, thanks for this!

[missinglink]

question: is de required here to get nl working or is this just nice to have since it solves the same problem in another language?

[emacgillavry]

It's the latter: it solve the same problem ;-)

[missinglink]

I recall us discussing this in the past, how this regex is better than the one sourced from the Chromium project.
One potential issue here is if we ever attempt to update the rest of them via the download script that this might get lost.

Since we haven't updated them so far I doubt its much of an issue, can we please just make sure this is covered with tests so they break if that happens and we investigate and fix it?

[emacgillavry]

I have submitted #145 to track adding tests for this.

[missinglink]

FYI: the npm module wasn't published due to that step being cancelled (not by me):

https://github.com/pelias/parser/runs/3535440988

[Joxit]

It seems that GitHub Actions had a Internal Error 😕