-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved support for streets with no suffix, such as "broadway" #141
Conversation
The build |
c5b5b6d
to
479e4d4
Compare
@Joxit are "Esplanade/Esplanades" common street types in French? git grep -i esplanade
...
resources/libpostal/dictionaries/fr/street_types.txt:esplanade|esp
resources/libpostal/dictionaries/fr/street_types.txt:esplanades|esps another one we might consider removing? resources/whosonfirst/dictionaries/locality/name:fra_x_preferred.txt:broadway |
Yes, Eslplanade is a common street/place type in French, always in the singular (without s)
Broadway can be safely removed 😄 |
479e4d4
to
7b2d7fd
Compare
Removed |
7b2d7fd
to
1b6eea1
Compare
Removed |
…ffix, such as "broadway"
1b6eea1
to
ca61e92
Compare
@@ -112,6 +112,11 @@ const testcase = (test, common) => { | |||
assert(`Paris 75000, France`, [ | |||
{ locality: 'Paris' }, { postcode: '75000' }, { country: 'France' } | |||
]) | |||
|
|||
// https://github.com/pelias/parser/pull/141#issuecomment-895230721 | |||
assert(`Esplanade de la Liberté`, [{ street: 'Esplanade de la Liberté' }]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for those test cases, I had actually broken the street prefix Esplanade
for French addresses 😱, but managed to fix them again after adding the examples 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😅 nice !
I think this is good to go @Joxit? It comes with a fair few test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this PR resolves the issue discussed in #140
it works by:
street
composite classifier config to re-classifystreet_proper_name+street_suffix
andstreet_proper_name
asstreet
no regressions, cc @kochis
resolves #140