Drop pthreads #15
Merged
Drop pthreads #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a restructuring without any intended side effect. The motivation is that this way telnet handling can go to telnet.c and so only affect telnet connections. Similar for can this should allow to get rid of the pipe and pthread stuff. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
|
This pull request introduces 2 alerts and fixes 1 when merging 59a8088 into 141c575 - view on LGTM.com new alerts:
fixed alerts:
|
Since there are ios specific read and write callbacks the needed overhead for can transfers can be implemented in these which makes the separate thread superfluous. This simplifies the can driver considerably. As a consequence microcom doesn't need pthreads any more and the respective changes in configure.ac can go away, too. The configuration for lgtm which assert that the AX_PTHREAD macro is available can be dropped and the travis configuration can be simplified accordingly. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Closes: pengutronix#8
|
This pull request fixes 1 alert when merging dc0d7aa into 141c575 - view on LGTM.com fixed alerts:
|
a3f
requested changes
Aug 25, 2019
a3f
approved these changes
Aug 25, 2019
|
I don't have the complete picture about your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally gets rid of the dependency to pthreads.