bootstrap test to run with symfony/http-foundation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianarb
force-pushed
the
feature/interop-http
branch
2 times, most recently
from
f9d0118
to
0e08b11
Compare
|
What about defining a common interface for the dispatcher? |
|
This interface is necessary. Have you proposal about this implementation? |
|
Not right now, I'll do some tests on it to see what could be a good one |
|
JFR #17 |
| @@ -5,8 +5,6 @@ | |||
| use Zend\Diactoros\Response; | |||
| use GianArb\Penny\Event\HttpFlowEvent; | |||
| use DI\ContainerBuilder; | |||
| use Psr\Http\Message\ResponseInterface; | |||
| use Psr\Http\Message\RequestInterface; | |||
There was a problem hiding this comment.
Why? Isnt a good idea to use same interface of community?
There was a problem hiding this comment.
@sensorario read #21
There was a problem hiding this comment.
@sensorario at the moment I don't use request and response into the framework, why should it constraint itself? :)
gianarb
force-pushed
the
feature/interop-http
branch
2 times, most recently
from
70aaa2a
to
f34a57b
Compare
gianarb
force-pushed
the
feature/interop-http
branch
from
f34a57b
to
fd2535b
Compare
gianarb
force-pushed
the
feature/interop-http
branch
from
fd2535b
to
d9af880
Compare
gianarb
pushed a commit
that referenced
this pull request
Sep 4, 2015
bootstrap test to run with symfony/http-foundation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #21