Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: add an EscapedByteSlice convenience wrapper #2437

Merged
merged 1 commit into from
May 1, 2023

Conversation

hdevalence
Copy link
Member

This may be helpful for debugging.

@hdevalence
Copy link
Member Author

hdevalence commented May 1, 2023

@zbuc I added this after seeing test output like

 insert nonconsensus change: [115, 99, 116, 47, 115, 116, 117, 98, 47, 115, 116, 97, 116, 101, 95, 99, 111, 109, 109, 105, 116, 109, 101, 110, 116, 95, 116, 114, 101, 101] -> [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 32, 0, 0, 0, 0, 0, 0, 0, 192, 180, 162, 133, 154, 38, 152, 23, 92, 175, 29, 115, 76, 223, 47, 11, 57, 3, 107, 124, 187, 99, 63, 190, 34, 149, 163, 200, 221, 245, 123, 13]

in the tests for #2429. Maybe it would be easier to read if we put this into the StateDelta as a tracing event using EscapedByteSlice at trace level or something? EDIT: did this as part of this commit.

@hdevalence hdevalence force-pushed the escaped-byte-slice branch from bf518ca to c010cf4 Compare May 1, 2023 01:38
@hdevalence hdevalence temporarily deployed to smoke-test May 1, 2023 01:38 — with GitHub Actions Inactive
@hdevalence hdevalence force-pushed the escaped-byte-slice branch from c010cf4 to 8cebc84 Compare May 1, 2023 06:43
This may be helpful for debugging.
@hdevalence hdevalence force-pushed the escaped-byte-slice branch from 8cebc84 to b20ef60 Compare May 1, 2023 06:50
@hdevalence hdevalence temporarily deployed to smoke-test May 1, 2023 06:50 — with GitHub Actions Inactive
@hdevalence hdevalence merged commit bf77d5b into main May 1, 2023
@hdevalence hdevalence deleted the escaped-byte-slice branch May 1, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant