Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration): Fix dex smoketests #2469

Merged
merged 3 commits into from
May 4, 2023
Merged

test(integration): Fix dex smoketests #2469

merged 3 commits into from
May 4, 2023

Conversation

zbuc
Copy link
Contributor

@zbuc zbuc commented May 4, 2023

The existing dex smoketests assumed the genesis liquidity pools would exist and were failing as a result.

They've been updated to exercise liquidity position opening to enable the swap to run.

We should probably add a full LP lifecycle test.

@zbuc zbuc changed the title Fix dex smoketests (test:integration) Fix dex smoketests May 4, 2023
@zbuc zbuc changed the title (test:integration) Fix dex smoketests test(integration): Fix dex smoketests May 4, 2023
@hdevalence
Copy link
Member

Rather than use 1cube, which is an NFT more subject to rounding errors, I think we should use gm or gn.

@zbuc zbuc temporarily deployed to smoke-test May 4, 2023 16:15 — with GitHub Actions Inactive
@zbuc zbuc merged commit ef73fde into main May 4, 2023
@zbuc zbuc deleted the dex_smoketests branch May 4, 2023 16:47
@cratelyn cratelyn added the A-dex Area: Relates to the dex label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants