dex(router): terminate execution based on the accurate path price #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to be a better solution than the temporary fix we did last week. Roughly, the idea is: - `fill_route` always makes progress, so it will return an exact price; - we can compare that exact price against the price limit. This prevents looping infinitely based on no-profit arbs that are mis-estimated as being epsilon less than the price limit -- as soon as one of them actually executes, the exact price will be computed and checked against the price limit, terminating the process.
erwanor
changed the title
erwanor
force-pushed
the
dex-termination-better
branch
from
ae0e03f
to
c1f72d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2676, #2675
This aims to be a better solution than the temporary fix we did last week. Roughly, the idea is:
fill_routealways makes progress, so it will return an exact price;This prevents looping infinitely based on no-profit arbs that are mis-estimated as being epsilon less than the price limit -- as soon as one of them actually executes, the exact price will be computed and checked against the price limit, terminating the process.