crypto: rework position var #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: plaidfinch <finch@penumbralabs.xyz>
There is an upstream method on `Boolean<FpVar<F>>` for constructing field elements from bits which is more efficient due to it using double and add, so let's use that. Co-Authored-By: plaidfinch <finch@penumbralabs.xyz>
redshiftzero
force-pushed
the
positionvar-rework
branch
from
bc13f3f to
f004999
Compare
redshiftzero
force-pushed
the
positionvar-rework
branch
from
7f5b63b to
74d0232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
PositionBitsVar, instead allocatingPositionVarfrom a UInt64 (64 bits) while storing the bit constraints so they can be used later, and then constructing a field element (needed for nullifier derivation integrity) from those bits such that it is range constrained.Boolean<Fq>