-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Summoning Ceremony Coordinator #3090
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
temporarily deployed
to
smoke-test
September 22, 2023 23:35 — with
GitHub Actions
Inactive
cronokirby
temporarily deployed
to
smoke-test
September 23, 2023 01:47 — with
GitHub Actions
Inactive
cronokirby
force-pushed
the
psumcoordd-init
branch
from
September 25, 2023 21:54
c3357e6
to
544c2d9
Compare
cronokirby
temporarily deployed
to
smoke-test
September 25, 2023 21:54 — with
GitHub Actions
Inactive
cronokirby
temporarily deployed
to
smoke-test
September 27, 2023 05:09 — with
GitHub Actions
Inactive
cronokirby
force-pushed
the
psumcoordd-init
branch
from
September 27, 2023 23:48
c498eeb
to
90b3a63
Compare
cronokirby
temporarily deployed
to
smoke-test
September 27, 2023 23:48 — with
GitHub Actions
Inactive
This will eventually be used as the coordinator, for now not much functionality beyond a basic hello world and view server integration.
This allows us to have a "single" module, and an "all" module, with the latter containing logic for doing all of the setups at once, and potentially in parallel.
cronokirby
force-pushed
the
psumcoordd-init
branch
from
October 4, 2023 08:16
bfffcb2
to
928195a
Compare
cronokirby
had a problem deploying
to
smoke-test
October 4, 2023 08:16 — with
GitHub Actions
Failure
We need big messages, this sets a 100 MIB limit, which is enough for phase2 by a factor of ~4.
cronokirby
had a problem deploying
to
smoke-test
October 5, 2023 08:07 — with
GitHub Actions
Failure
Add summonerd files
cronokirby
force-pushed
the
psumcoordd-init
branch
from
October 5, 2023 08:09
ef6e1f2
to
b2699f4
Compare
redshiftzero
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - LGTM!
For the interested observer, one can test this via:
- Running the summoner server via
cargo run --release --bin summonerd start
- In a second window, participate in the ceremony via
cargo run --release --bin pcli ceremony contribute --coordinator-url http://127.0.0.1:8081
After a while in the window with pcli
you should see that your contribution was confirmed 🌈
CI failure here is only due to the changes to the protobufs, so merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3139.
The status of the summoner coordinator at the end of this is that you can do real phase2 contributions, but without a persistent server, and without any kind of bidding mechanism, just sortition of pending participants.