Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for summonerd webapp #3257

Merged
merged 7 commits into from
Nov 1, 2023
Merged

updates for summonerd webapp #3257

merged 7 commits into from
Nov 1, 2023

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Oct 31, 2023

Closes #3220

This splits the web app into three pages.

Main page

This currently displays the current phase, where the current phase info is determined by looking in the database to see if the transition between phase 1 and 2 has occurred.

It also contains instructions for this phase, where the --phase CLI arg is populated using the information determined as above.

Remaining TODOs:

  • [-] Populate the text on the page with the COORDINATOR_URL and SUMMONER_ADDRESS - no longer needed as we will hardcode these in pcli to simplify the user's experience

/phase/1 and /phase/2 pages

These are identical pages, one per phase, that show the:

  • The number of contributions in that phase
  • The most recent 5 contributions: short address, hash, time of contribution completed

Remaining TODOs:

  • Show most recent bid amount
  • If phase is currently active, show the number of folks connected

@redshiftzero redshiftzero temporarily deployed to smoke-test October 31, 2023 18:43 — with GitHub Actions Inactive
@redshiftzero redshiftzero changed the title updates for webapp updates for summonerd webapp Oct 31, 2023
@cronokirby cronokirby temporarily deployed to smoke-test November 1, 2023 01:31 — with GitHub Actions Inactive
@cronokirby cronokirby temporarily deployed to smoke-test November 1, 2023 07:52 — with GitHub Actions Inactive
This is just the number of connected participants, the top, and median
bid, but nothing else for now
@cronokirby cronokirby temporarily deployed to smoke-test November 1, 2023 10:56 — with GitHub Actions Inactive
@cronokirby
Copy link
Contributor

Instead of populating the text on page, we should simply make pcli have default arguments for these two in the code.

@cronokirby
Copy link
Contributor

Also, I don't see why we wouldn't just display all the contributions; thousands shouldn't be an issue.

@cronokirby cronokirby marked this pull request as ready for review November 1, 2023 17:07
@redshiftzero redshiftzero temporarily deployed to smoke-test November 1, 2023 17:19 — with GitHub Actions Inactive
@redshiftzero redshiftzero merged commit 098df1a into main Nov 1, 2023
@redshiftzero redshiftzero deleted the summonerd-webapp-2 branch November 1, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ceremony progress web view
2 participants