Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(summonerd): use latest pcli version #3471

Merged
merged 1 commit into from
Dec 4, 2023
Merged

docs(summonerd): use latest pcli version #3471

merged 1 commit into from
Dec 4, 2023

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Dec 4, 2023

Bumps the recommended version of pcli to v0.63.3, to match the latest point release [0]. Also removes the cargo run invocations to match the recent change to the docs, to recommend installing binaries over compiling from source [1].

[0] #3469
[1] #3442

@conorsch
docs(summonerd): use latest pcli version
2860f78 
Bumps the recommended version of pcli to v0.63.3, to match the latest
point release [0]. Also removes the `cargo run` invocations to match
the recent change to the docs, to recommend installing binaries over
compiling from source [1].

[0] #3469
[1] #3442
@conorsch conorsch requested a review from cronokirby December 4, 2023 22:56
cronokirby
cronokirby approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think switching to using pcli ultimately helps because we can easily say things like "run pcli <command>" for troubleshooting other things.

@conorsch conorsch marked this pull request as ready for review December 4, 2023 23:25
@conorsch conorsch merged commit ce49a4e into summonerd-feature-branch Dec 4, 2023
@conorsch conorsch deleted the summonerd-bump-pcli-version branch December 4, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cronokirby cronokirby cronokirby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conorsch @cronokirby