Remove wallet id filter from view service #3557
Conversation
grod220
force-pushed
the
remove-wallet-from-view
branch
from
9cc3916 to
f88c799
Compare
There was a problem hiding this comment.
Critical thing to review. Proto messages have been updated.
There was a problem hiding this comment.
Think RustRover reformats the imports in this way to make publicly exposed exports at the top
There was a problem hiding this comment.
kind of noisy but seems fine. there's a way to get cargo fmt to do this but it requires using nightly rustfmt and a custom config and that seemed like an unacceptable DX tax to put on every contributor, but the effect is that our imports don't stay tidy. so occasionally having them all cleaned up seems fine.
| // | ||
| // View protocol requests optionally include the wallet id, used to | ||
| // identify which set of data to query. |
There was a problem hiding this comment.
If we did want to have a multi-tenant view service in the future, we could do so by putting the wallet ID in the request headers. This would be reasonably easy to implement on the Rust side. But not important for now, just noting that the option is open.
Closes penumbra-zone/web#334
Only one wallet is active at a time for the view service. Therefore, we can remove all of these
wallet_idfilters for it.