chain: move fmd parameters to shielded-pool #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
force-pushed
the
erwan/3617_part_1
branch
from
95ca083 to
e531e13
Compare
In #3640, we added two helper methods: - `increase_token_supply` - `decrease_token_supply` These methods are somewhat similar, and objectively are more verbose than a single `update_token_supply` method. However, it seems an improvement to not have to do any cognitive work to piece together whether a method call increases or decreases the token supply. Another advantage of this approach is that one can easily use rust-analyzer to filter for places that increase the token supply vs. places where it is being shrinked.
erwanor
force-pushed
the
erwan/3617_part_1
branch
from
b3327e8 to
7c6c1e8
Compare
erwanor
force-pushed
the
erwan/3617_part_1
branch
from
7c6c1e8 to
807b4e1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3617, I wanted to stuff more things in my first pass. But this ended up to be a decent amount of change surface, so opening a PR early before doing the rest.