Add support for fee tiers to TransactionPlannerRequest #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
changed the title
hdevalence
reviewed
Feb 2, 2024
hdevalence
reviewed
Feb 2, 2024
|
Pairing with @jessepinho led to the discovery of a large amount of friction in actually using these parameters but also ideas on how we can radically simplify the planning code, once we split out the current wasm crate into a minimal bindings part and an extension implementation part. |
|
@hdevalence looks like I can't hit the approve button since I authored the PR, but 👍🏻 — feel free to self-merge |
hdevalence
deleted the
jessepinho/fee-tier-support-in-transaction-planner-request
branch
TalDerei
pushed a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to set a fee tier in a
TransactionPlannerRequest. This blocks penumbra-zone/web#309 (supporting fee tiers on web), because the only way to plan a transaction on web is to pass aTransactionPlannerRequestto the extension's view service.This PR adds support for fee tiers to
TransactionPlannerRequest.Reviewers might want to look at the first commit on its own, since that's where I changed the
.protofile; the second commit is simply the result of runningprotobuf-codegen.Note that linting fails in this PR due to breaking changes in the
TransactionPlannerRequestprotobuf definition.Related issue: #3724