-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staking: break out staking component into modular traits #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3857541
to
8f8daff
Compare
4f75dfc
to
af80172
Compare
Since this is largely following the #3615 design issue (modulo some renaming), I will merge this optimistically. Next up is adjusting the state-keys, and finally, fixing the issues surfaced during the validator state machine review. |
TalDerei
pushed a commit
that referenced
this pull request
Feb 8, 2024
* staking: move the action handlers to `component` * staking: break out component impl * staking: break out validator manager * staking(validator_manager): fix warnings / improve comments * staking(validator_manager): add `update_validator` * staking(validator_manager): scaffolding for `ValidatorDataRead` * staking(validator_manager): break out validator state getters * penumbra: `fmt` * staking(epoch_handler): break out end-epoch logic * staking(validator_handler): rename module * staking(validator_handler): track manager * staking(validator_store): flesh out `ValidatorDataRead` * staking(validator_manager): use internal traits * staking(component): move epoch handling to `EpochHandler` * penumbra: propagate staking component api * penumbra: remove unused imports * staking(component): clean component root * staking(component): prepare breaking out slashing data read * staking(component): fix holdover `metrics@0.22` changes * staking(validator_store): add stateless `compute_unbonding_delay`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #3615.