staking: use block height to enforce unbonding delay #3923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
the
A-staking
erwanor
added
consensus-breaking
erwanor
force-pushed
the
erwan/3738_unbonding_work_better
branch
from
d16af48 to
ec85a43
Compare
cratelyn
approved these changes
Mar 11, 2024
This will let us provide useful error messages in case there is a rate data mismatch when we execute the delegate action.
This commit implements `compute_unbonding_height` which returns the allowed unbonding height for an undelegation that has started at some previous arbitrary time. It consults the validator pool's unbonding state short-circuiting the unbonding delay if the pool is already unbonded.
This will allow us to _not_ have to maintain a reverse (epoch index -> epoch) index.
erwanor
force-pushed
the
erwan/3738_unbonding_work_better
branch
from
cf7be8c to
bed50ce
Compare
|
Thanks for the review @cratelyn, rebased conflicts, then merging this so we can start work on integration. |
|
merged on your behalf ⭐ |
conorsch
added a commit
that referenced
this pull request
Mar 15, 2024
Follow-up to changes made in [0], where we settled on "unbonded delay" rather than "unbonding epochs" to describe how many blocks must elapse until undelegated stake becomes claimable. The `pd` CLI options are only used by developers, so I'm not worried about breaking operator scripts in the wild. [0] #3923
conorsch
added a commit
that referenced
this pull request
Mar 15, 2024
Follow-up to changes made in [0], where we settled on "unbonded delay" rather than "unbonding epochs" to describe how many blocks must elapse until undelegated stake becomes claimable. The `pd` CLI options are only used by developers, so I'm not worried about breaking operator scripts in the wild. [0] #3923
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3738, this PR makes the unbonding mechanism based on block delay rather than epochs. In practice, this means that a user will wait X blocks for a validator pool to unbond (rather than Y epochs).
To achieve this, this PR:
StakeParamater::unbonding_delaymeasured in blocksstart_heightstart_epoch_indexfields in delegate/claim actionsepoch_indexfrom validatorRateDatas2.013718unbonding_start_at_1540_penumbravalid1(vs._epoch_XXX)Important point about the mechanism: we bind tokens to the starting height of the epoch that they belong to. This let us avoid binding transactions to specific block heights.