view(rpc): add DelegationsByAddressIndex query
#3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
force-pushed
the
jessepinho/delegation-balances-rpc-web-612
branch
from
5c6251a to
aa568ef
Compare
jessepinho
force-pushed
the
jessepinho/delegation-balances-rpc-web-612
branch
from
82cd410 to
097dd6d
Compare
jessepinho
force-pushed
the
jessepinho/delegation-balances-rpc-web-612
branch
from
097dd6d to
83339b6
Compare
erwanor
changed the title
DelegationsByAddressIndex to query service
erwanor
changed the title
DelegationsByAddressIndex to query serviceDelegationsByAddressIndex query
zbuc
reviewed
Mar 11, 2024
| &self, | ||
| _request: tonic::Request<pb::DelegationsByAddressIndexRequest>, | ||
| ) -> Result<tonic::Response<Self::DelegationsByAddressIndexStream>, tonic::Status> { | ||
| unimplemented!("delegations_by_address_index") |
There was a problem hiding this comment.
Looks like this PR isn't ready yet?
There was a problem hiding this comment.
Well, the idea is that it could be implemented by other implementations of ViewService, such as in the web app. (Note that fn authorize_and_build above is also unimplemented.) I had to add this method here or else the Rust compiler would complain that this method was missing.
erwanor
approved these changes
Mar 11, 2024
|
@erwanor I'd accidentally left this as a draft PR — that's prob why! :D |
conorsch
pushed a commit
that referenced
this pull request
Mar 13, 2024
## Describe your changes Right now, the `StakingService` has a method, `validatorInfo`, that returns a series of `ValidatorInfo`s. As of penumbra-zone/web#604, we've refactored the minifront staking page to treat validators as tokens that an address may have a balance of. To achieve that, [we're fetching validator infos, then generating `ValueView`s from those validators](https://github.com/penumbra-zone/web/pull/604/files#diff-9bd971ea2f5dadcc555a9a848d1cea2a0d6df1a0069b9e5e490218058ac5adbc) that include the address's balance of those tokens. This logic should be moved into a new RPC method on the `ViewService` called `DelegationsByAddressIndex`, since it's a common enough use case that clients shouldn't all have to do it themselves. Relevant changes are to [`view.proto`](https://github.com/penumbra-zone/penumbra/pull/3984/files#diff-03b7341d5bf81ab9c8d8542d220d5ba4ae122bd3837531309742b685d7ec1619) and [`ViewService`](https://github.com/penumbra-zone/penumbra/pull/3984/files#diff-36188e6ab5083e8be9d29039370cc523cfcfede683b223327b2d90e3f75d40c7); the rest is just codegen changes. ## Issue ticket number and link Closes penumbra-zone/web#612 ## Checklist before requesting a review - [x] (n/a) If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. (cherry picked from commit eb4f5e4)
conorsch
pushed a commit
that referenced
this pull request
Mar 13, 2024
Right now, the `StakingService` has a method, `validatorInfo`, that returns a series of `ValidatorInfo`s. As of penumbra-zone/web#604, we've refactored the minifront staking page to treat validators as tokens that an address may have a balance of. To achieve that, [we're fetching validator infos, then generating `ValueView`s from those validators](https://github.com/penumbra-zone/web/pull/604/files#diff-9bd971ea2f5dadcc555a9a848d1cea2a0d6df1a0069b9e5e490218058ac5adbc) that include the address's balance of those tokens. This logic should be moved into a new RPC method on the `ViewService` called `DelegationsByAddressIndex`, since it's a common enough use case that clients shouldn't all have to do it themselves. Relevant changes are to [`view.proto`](https://github.com/penumbra-zone/penumbra/pull/3984/files#diff-03b7341d5bf81ab9c8d8542d220d5ba4ae122bd3837531309742b685d7ec1619) and [`ViewService`](https://github.com/penumbra-zone/penumbra/pull/3984/files#diff-36188e6ab5083e8be9d29039370cc523cfcfede683b223327b2d90e3f75d40c7); the rest is just codegen changes. Closes penumbra-zone/web#612 - [x] (n/a) If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. (cherry picked from commit eb4f5e4) Also includes a manual regen of the proto files, post-cherry-pick onto the release branch.
conorsch
pushed a commit
that referenced
this pull request
Mar 13, 2024
Right now, the `StakingService` has a method, `validatorInfo`, that returns a series of `ValidatorInfo`s. As of penumbra-zone/web#604, we've refactored the minifront staking page to treat validators as tokens that an address may have a balance of. To achieve that, [we're fetching validator infos, then generating `ValueView`s from those validators](https://github.com/penumbra-zone/web/pull/604/files#diff-9bd971ea2f5dadcc555a9a848d1cea2a0d6df1a0069b9e5e490218058ac5adbc) that include the address's balance of those tokens. This logic should be moved into a new RPC method on the `ViewService` called `DelegationsByAddressIndex`, since it's a common enough use case that clients shouldn't all have to do it themselves. Relevant changes are to [`view.proto`](https://github.com/penumbra-zone/penumbra/pull/3984/files#diff-03b7341d5bf81ab9c8d8542d220d5ba4ae122bd3837531309742b685d7ec1619) and [`ViewService`](https://github.com/penumbra-zone/penumbra/pull/3984/files#diff-36188e6ab5083e8be9d29039370cc523cfcfede683b223327b2d90e3f75d40c7); the rest is just codegen changes. Closes penumbra-zone/web#612 - [x] (n/a) If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. (cherry picked from commit eb4f5e4) Also includes a manual regen of the proto files, post-cherry-pick onto the release branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Right now, the
StakingServicehas a method,validatorInfo, that returns a series ofValidatorInfos.As of penumbra-zone/web#604, we've refactored the minifront staking page to treat validators as tokens that an address may have a balance of. To achieve that, we're fetching validator infos, then generating
ValueViews from those validators that include the address's balance of those tokens.This logic should be moved into a new RPC method on the
ViewServicecalledDelegationsByAddressIndex, since it's a common enough use case that clients shouldn't all have to do it themselves.Relevant changes are to
view.protoandViewService; the rest is just codegen changes.Issue ticket number and link
Closes penumbra-zone/web#612
Checklist before requesting a review