auction: ActionDutchAuction* validation and component impl
#4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
force-pushed
the
erwan/4211_validate_actions
branch
from
47859fa to
3c29ba3
Compare
This is a bit more verbose, but this makes the callsites more readable because we can just do `auction_store::by_id` and the context becomes self-evident.
erwanor
force-pushed
the
erwan/4211_validate_actions
branch
from
1d0bf7d to
8347506
Compare
erwanor
changed the title
ActionDutchAuction* validationActionDutchAuction* validation and component impl
cratelyn
reviewed
Apr 17, 2024
crates/core/component/auction/src/component/action_handler/dutch/end.rs
Outdated
Show resolved
Hide resolved
cratelyn
reviewed
Apr 17, 2024
crates/core/component/auction/src/component/action_handler/dutch/schedule.rs
Outdated
Show resolved
Hide resolved
cratelyn
reviewed
Apr 17, 2024
cratelyn
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds validation logic for:
ActionDutchAuctionScheduleActionDutchAuctionEndActionDutchAuctionWithdrawand a component implementation, on a model similar-but-simpler to the DEX:
DutchAuctionManagerextension trait defines a crate-level API to effect a validated actionInnerinternal implementation manages writing to the stateAuctionStoreReadtrait which manage tentatively deserializing raw auction state (wktAny) into a useful domain type.Issue ticket number and link
#4211
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: