final changes to circuits #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that in no circuit is it ever allowed that the `ak` is the identity element. Previously, we were separately checking the `ak` is not identity in each of the three places we were using it: `SwapClaimCircuit`, `SpendCircuit`, and `DelegatorVoteCircuit`
We use `AddressVar` in five circuits: * `SwapClaimCircuit` and `SwapCircuit` via the `SwapPlaintextVar` claim address * `DelegatorVoteCircuit`, `SpendCircuit`, `OutputCircuit` via the `NoteVar` In all cases we were doing the diversified base identity check in the circuit already, _except_ for the `SwapCircuit`, since when we go to claim the swap, we were checking the diversified base there.
redshiftzero
force-pushed
the
zk-circuit-staging
branch
from
66bf53f to
08d5a79
Compare
redshiftzero
force-pushed
the
zk-circuit-staging
branch
from
08d5a79 to
6b0fd13
Compare
redshiftzero
force-pushed
the
zk-circuit-staging
branch
from
6b0fd13 to
6b8e89f
Compare
redshiftzero
changed the title
redshiftzero
added
the
consensus-breaking
cronokirby
approved these changes
May 13, 2024
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Makes suggested changes to the circuits prior to a final audit
Issue ticket number and link
Closes #4280
Checklist before requesting a review