Correct display of downtime in pcli validator query uptime
#4442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The downtime penalty is 0.01%, not 1% as previously displayed. This corrects the erroneous calculation which previously displayed an incorrect figure by a 100x factor. Signed-off-by: plaidfinch <finch@starlingcyber.net>
plaidfinch
added
A-client
cratelyn
reviewed
May 23, 2024
Co-authored-by: katelyn martin <katelyn@penumbralabs.xyz> Signed-off-by: Erwan Or <erwan.ounn.84@gmail.com>
erwanor
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The downtime penalty is 0.01%, not 1% as previously displayed. This corrects the erroneous calculation which previously displayed an incorrect figure by a 100x factor.
Describe your changes
This adds a
/ 100.0to correct the missing factor, and an explanatory comment.Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: