Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view: don't record invalid and corrupted Metadata #4453

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

hdevalence
Copy link
Member

This doesn't solve the problem that the metadata will be missing, but it does at least avoid corrupting the database.

Closes #4452

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    only changes client code

This doesn't solve the problem that the metadata will be missing, but it does
at least avoid corrupting the database.

Closes #4452
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this look good, thank you for fixing this 🩹

@hdevalence hdevalence merged commit 975ad7d into main May 24, 2024
13 checks passed
@hdevalence hdevalence deleted the try-fix-4452 branch May 24, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ViewService/Balances Response Streams Terminate with an Error
2 participants