ibc: remediate remaining monorepo issues from zellic audit #4558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
approved these changes
Jun 6, 2024
| // | ||
| // relevant ibc-go code: | ||
| // https://github.com/cosmos/ibc-go/blob/main/modules/light-clients/07-tendermint/upgrade.go#L74 | ||
| // https://github.com/cosmos/ibc-go/blob/2555a7c504a904064d659e4c1a3a74000887f73d/modules/core/02-client/keeper/keeper.go#L552-L564 |
There was a problem hiding this comment.
Interesting. I realize we haven't tested counterparty host chain upgrade ever, maybe we should do that.
erwanor
added
A-IBC
conorsch
reviewed
Jun 10, 2024
| @@ -328,7 +328,7 @@ async fn main() -> anyhow::Result<()> { | |||
| let randomizer = OsRng.gen::<u32>(); | |||
| let chain_id = | |||
| chain_id.unwrap_or_else(|| env!("PD_LATEST_TESTNET_NAME").to_string()); | |||
| format!("{}-{}", chain_id, hex::encode(randomizer.to_le_bytes())) | |||
| format!("{}-{}", chain_id, randomizer) | |||
There was a problem hiding this comment.
N.B. this will update preview/devnet chain ids to a format like penumbra-testnet-deimos-8-722430144, where the lattermost chunk is understood as a revision. Off the cuff, it might make more sense for the cli to default to rev 0 for devnets, but that's a bikeshedding conversation for another day. Thanks for fixing!
conorsch
added a commit
that referenced
this pull request
Jun 17, 2024
We automatically append a hex randomizer to devnet/preview chain ids, to avoid collisions. Client tooling may expect that suffix to be a revision number, a behavior we want to avoid. Let's stick an 'x' in the randomizer to prevent this behavior. Follow-up to #4558. Revisits and therefore closes #4552.
1 task
avahowell
pushed a commit
that referenced
this pull request
Jun 17, 2024
We automatically append a hex randomizer to devnet/preview chain ids, to avoid collisions. Client tooling may expect that suffix to be a revision number, a behavior we want to avoid. Let's stick an 'x' in the randomizer to prevent this behavior. Follow-up to #4558. Revisits and therefore closes #4552.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4549
Closes #4552
Closes #4553
Closes #4550
Closes #4546