Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single result file per sample if given {record_identifier} in the result_file_path #123

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

donaldcampbelljr
Copy link
Contributor

Allow pipestat to use a single result file per sample if given {record_identifier} in the result_file_path.

Then, if multiple result files are used, summarize, table, and link will search for the result.yaml files, aggregate them and use the aggregated results.

Related to:
#120
databio/pepatac#257
databio/pepatac#256

@donaldcampbelljr donaldcampbelljr changed the base branch from master to dev November 29, 2023 20:42
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (76d79d9) 34.13% compared to head (03d7d1a) 34.06%.
Report is 2 commits behind head on dev.

❗ Current head 03d7d1a differs from pull request most recent head 17563fd. Consider uploading reports for the commit 17563fd to get more accurate results

Files Patch % Lines
pipestat/backends/file_backend/filebackend.py 19.04% 17 Missing ⚠️
pipestat/helpers.py 16.66% 10 Missing ⚠️
pipestat/pipestat.py 47.05% 9 Missing ⚠️
pipestat/reports.py 0.00% 3 Missing ⚠️
pipestat/backends/abstract.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #123      +/-   ##
==========================================
- Coverage   34.13%   34.06%   -0.08%     
==========================================
  Files          21       21              
  Lines        3269     3323      +54     
==========================================
+ Hits         1116     1132      +16     
- Misses       2153     2191      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donaldcampbelljr donaldcampbelljr merged commit e52adc2 into dev Nov 30, 2023
3 checks passed
@donaldcampbelljr donaldcampbelljr deleted the dev_multi_results branch November 30, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant