PMM-10271 Fix meta-metric label for general collector #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meta-metric generated for general collector were incorrectly labeled as dbstats. When dbstats and general collector were executed for a scrape request, two metric were generated with the same name and labels. This duplicate metric would trigger a panic in the metric generation library. This change updates the label for general collector and fixes the issue.
denisok
approved these changes
Jul 7, 2022
|
|
ShashankSinha252
commented
Jul 7, 2022
| filter := []string{ | ||
| "collector_scrape_time_ms", | ||
| } | ||
| count := testutil.CollectAndCount(c, filter...) |
There was a problem hiding this comment.
Metric value may fluctuate for every run. Hence checking only presence of metric.
ShashankSinha252
commented
Jul 7, 2022
| filter = []string{ | ||
| "mongodb_up", | ||
| } | ||
| err := testutil.CollectAndCompare(c, expected, filter...) |
There was a problem hiding this comment.
Comparing required metric and ignoring everything else.
ritbl
approved these changes
Jul 7, 2022
BupycHuk
approved these changes
Jul 7, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for PMM-10271 and PMM-10279
Meta-metric generated for general collector were incorrectly labeled as dbstats. When dbstats and general collector were executed for a scrape request, two metric were generated with the same name and labels. This duplicate metric would trigger a panic in the metric generation library. This change updates the label for general collector and fixes the issue.
FB link : Percona-Lab/pmm-submodules#2627