PMM-12350 Reduce error logs from diagnostic data on arbiter nodes #819
Conversation
idoqo
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| port, err := tu.PortForContainer(container) | ||
| require.NoError(t, err) | ||
|
|
||
| exporterOpts := &Opts{ |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
exporter.Opts is missing fields CollStatsNamespaces, CollStatsLimit, CompatibleMode, ConnectTimeoutMS, DisableDefaultRegistry, DiscoveringMode, ProfileTimeTS, TimeoutOffset, CurrentOpSlowTime, CollectAll, EnableDBStats, EnableDBStatsFreeStorage, EnableReplicasetStatus, EnableCurrentopMetrics, EnableTopMetrics, EnableIndexStats, EnableCollStats, EnableProfile, EnableShards, EnableOverrideDescendingIndex, IndexStatsCollections (exhaustruct)
| @@ -236,6 +237,29 @@ func TestAllDiagnosticDataCollectorMetrics(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestDiagnosticErrorLogs(t *testing.T) { | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
Function TestDiagnosticErrorLogs missing the call to method parallel (paralleltest)
| @@ -199,6 +200,39 @@ func TestMongoS(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestArbiterCollectors(t *testing.T) { | |||
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
Function TestArbiterCollectors missing the call to method parallel (paralleltest)
| r := e.makeRegistry(ctx, client, new(labelsGetterMock), *e.opts) | ||
|
|
||
| res := r.Unregister(rsgsc) | ||
| assert.Equal(t, false, res) |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
bool-compare: use assert.False (testifylint)
|
Wrong ticket ), closing in favour of #820 |
PMM-12350 (optional, if ticket reported)
Below we provide a basic checklist of things that would make it a good PR:
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.