Skip to content

Fix leaked var in tde archiver tools #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
Merged

Fix leaked var in tde archiver tools #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dad871e
Fix leaked var in tde archiver tools
dAdAbird Aug 18, 2025
01584bb
Suppress LSAN complaints on pgbench
dAdAbird Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ci_scripts/suppressions/lsan.supp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,8 @@ leak:GenerateRecoveryConfig
# Returns strdup'd string which never gets freed in frontend tools. Trying to
# free it leads to comiler complains that it discards 'const' qualifier.
leak:get_progname

# A buch of not freed allocations in putVariableInt right before exit(1). And
# malloced `threads` ("Thread state") never gets released (allocated in main(),
# once, and not in loop).
leak:bin/pgbench/pgbench.c
2 changes: 2 additions & 0 deletions contrib/pg_tde/src/bin/pg_tde_archive_decrypt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,8 @@ main(int argc, char *argv[])
if (system(command) != 0)
pg_fatal("ARCHIVE-COMMAND \"%s\" failed: %m", command);

free(command);

if (issegment)
{
if (unlink(tmppath) < 0)
Expand Down
2 changes: 2 additions & 0 deletions contrib/pg_tde/src/bin/pg_tde_restore_encrypt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,8 @@ main(int argc, char *argv[])
if (system(command) != 0)
pg_fatal("RESTORE-COMMAND \"%s\" failed: %m", command);

free(command);

if (issegment)
{
write_encrypted_segment(targetpath, sourcename, tmppath);
Expand Down