Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clarification about interface builder references #687

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Add clarification about interface builder references #687

merged 2 commits into from
Dec 19, 2023

Conversation

rogerluan
Copy link
Contributor

Resolves #663 — I created that issue because there was no info on the README. Since this has now been clarified, I'm documenting that knowledge in the README so it's available more easily.
Relates to #212

@rogerluan rogerluan mentioned this pull request Dec 18, 2023
Closed
ileitch
ileitch requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ileitch ileitch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Please move it into a new sub-section titled Interface Builder under Analysis at the bottom, below XCTestCase.

@rogerluan rogerluan requested a review from ileitch December 19, 2023 17:43
@ileitch ileitch merged commit b50fb22 into peripheryapp:master Dec 19, 2023
6 checks passed
@rogerluan rogerluan deleted the roger/add-clarification-about-ib branch December 19, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ileitch ileitch Awaiting requested review from ileitch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how Periphery treats references to storyboards/xibs
2 participants
@rogerluan @ileitch