Address staticcheck issues #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bradfitz
commented
Jan 15, 2024
bradfitz
commented
- pkg/client: fix staticcheck warnings
- pkg/server: fix staticcheck warnings
- all: address a bunch more staticcheck warnings
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com> Signed-off-by: Brad Fitzpatrick <brad@danga.com>
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com> Signed-off-by: Brad Fitzpatrick <brad@danga.com>
And temporarily disable a few classes of errors in staticcheck.conf for now, to be addressed later together. Signed-off-by: Brad Fitzpatrick <brad@danga.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.