Skip to content

support OGP #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2020
Merged

support OGP #23

merged 3 commits into from
Oct 3, 2020

Conversation

kfly8
Copy link
Contributor

@kfly8 kfly8 commented Feb 8, 2020 •
edited
Loading

  • OGPのメタ要素をいれる
  • og image をいい感じにする

@kfly8 kfly8 linked an issue Feb 8, 2020 that may be closed by this pull request
OGP対応 #21
Closed
2 tasks
@kfly8
Copy link
Contributor Author

kfly8 commented Feb 8, 2020

og imageはこんな感じで良い？

image

@kfly8
Copy link
Contributor Author

kfly8 commented Feb 8, 2020

cloudinaryに依存しているので、よしなにしたい

@kfly8
Copy link
Contributor Author

kfly8 commented Feb 10, 2020

画像にテキストを載せる用途だけなら、手元で作ってしまっても規模小さくて済みそう？
かといって、ImageMagickに依存させると面倒ごとが増える。
golangにする？

@kfly8 kfly8 marked this pull request as ready for review October 2, 2020 13:57
@kfly8
Copy link
Contributor Author

kfly8 commented Oct 2, 2020

こんな感じにしてみた。

image

@github-actions
Copy link

github-actions bot commented Oct 2, 2020

🚀 Deployed on https://5f77322f422a4d37e4406b41--kind-babbage-e8fbc8.netlify.app

@kfly8
微調整 (#23)
1cd4411 
- タイトル、筆者に、カンマを使えるようにする
- 背景画像を差し替え
@github-actions
Copy link

github-actions bot commented Oct 3, 2020

🚀 Deployed on https://5f77fe4ab714649126cbc7af--kind-babbage-e8fbc8.netlify.app

@kfly8
Copy link
Contributor Author

kfly8 commented Oct 3, 2020

Twitter cardでこんな感じ。

image

@kfly8 kfly8 merged commit 88968ba into content Oct 3, 2020
@kfly8 kfly8 deleted the ogp branch October 3, 2020 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OGP対応
1 participant
@kfly8