Correct require on relative path #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update .travis.yml to run test also on Perl 5.26. Travis CI already has Perl 5.26 binaries prepared. |
|
I enabled Perl 5.26 for Travis CI and AppVeyor in this PR: #137 |
|
#137 is merged. Can you rebase on top of current master? |
Without the leading `./`, "require" will search `@INC` which no longer always contains the current directory.
|
Rebased |
|
#137 was reverted in master, together with all fixes for 5.26. Great! |
|
So no checks. |
|
sorry to ask again, could you please rebase. I merged a PR to fix Travis builds. Thanks! |
|
Thanks for your contribution! I finally merged it into master here: 5480266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the leading
./, "require" will search@INCwhich no longer always contains the current directory. See https://metacpan.org/pod/release/XSAWYERX/perl-5.26.0/pod/perldelta.pod#Removal-of-the-current-directory-(%22.%22)-from-@INC