examples-compilation.t memory and code quality #2812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping code in `if False` is not necessary anymore when not using EVAL, refs Raku#2798.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to address #2798. This restores a rough test plan, now showing the number of files in the test and processing each file in a subtest. I've also removed an
if Falsewrapper around non-solocode which was needed to prevent EVAL from executing code. I don't see how any more can be eliminated to close that issue. Suggestions welcome.Concerning #2764, I've run the test five times on
doc/Type/*.pod6measuring maximum memory usage and cpu time usingTelemetryand computed mean and std. deviation:max-rssµcpuµmax-rssσcpuσ