Expect Exception, not X::AdHoc.

The test suite we ship for 6.christmas should ideally be a subset of
the 6.d suite, and later ones. Testing against `Exception` frees us
to add further typed exceptions without breaking the promise in the
existing tests. Testing againt `X::AdHoc` does not.

Author: jnthn

S02-types/bag.t

@@ -488,7 +488,7 @@ sub showkv($x) {
       'Make sure we cannot assign on a key';
 
     throws-like { $_ = 666 for $b.values },
-     X::AdHoc,   # X::Assignment::RO ???
+     Exception,   # X::Assignment::RO ???
       'Make sure we cannot assign on a .values alias';
 
     throws-like { .value = 999 for $b.pairs },

S02-types/declare.t

@@ -114,7 +114,7 @@ plan 70;
 
 #?rakudo.jvm todo "RT #126526"
 {
- throws-like { my int $namcu; $namcu = 2**100 }, X::AdHoc,
+ throws-like { my int $namcu; $namcu = 2**100 }, Exception,
     message => 'Cannot unbox 101 bit wide bigint into native integer',
     "Assign big bigint to native won't overflow silently";
 }

S02-types/mix.t

@@ -430,7 +430,7 @@ sub showkv($x) {
       'Make sure we cannot assign on a key';
 
     throws-like { $_ = 666.1 for $m.values },
-      X::AdHoc,  # X::Assignment::RO  ???
+      Exception,  # X::Assignment::RO  ???
       'Make sure we cannot assign on a .values alias';
 
     throws-like { .value = 999.1 for $m.pairs },
@@ -459,7 +459,7 @@ sub showkv($x) {
     my %h3;
     for $m.antipairs -> \p { %h3{p.value} = p.key }
     is %h3.sort, (a=>1.1, b=>2.2, c=>3.3, d=>4.4), 'did we see all the antipairs';
-    throws-like { for $m.kxxv -> \k { say k } }, X::AdHoc, 'cannot call kxxv';
+    throws-like { for $m.kxxv -> \k { say k } }, Exception, 'cannot call kxxv';
 }
 
 # vim: ft=perl6

S02-types/mixhash.t

@@ -501,7 +501,7 @@ sub showkv($x) {
     my %h3;
     for $m.antipairs -> \p { %h3{p.value} = p.key }
     is %h3.sort, (a=>1.1, b=>2.2, c=>3.3, d=>4.4), 'did we see all the antipairs';
-    throws-like { for $m.kxxv -> \k { say k } }, X::AdHoc, 'cannot call kxxv';
+    throws-like { for $m.kxxv -> \k { say k } }, Exception, 'cannot call kxxv';
 }
 
 # vim: ft=perl6

S02-types/set.t

@@ -220,11 +220,11 @@ sub showset($s) { $s.keys.sort.join(' ') }
     is showset(-« set(3, 9, -4)), '-9 -3 4', '-« Set';
     is showset(set(<b e g k z>)».pred), 'a d f j y', 'Set».pred';
 
-    throws-like { set(1, 2) »+« set(3, 4) }, X::AdHoc,'Set »+« Set is illegal';
-    throws-like { set(1, 2) »+« [3, 4] }, X::AdHoc, 'Set »+« Array is illegal';
-    throws-like { set(1, 2) «+» [3, 4] }, X::AdHoc, 'Set «+» Array is illegal';
-    throws-like { [1, 2] »+« set(3, 4) }, X::AdHoc, 'Set »+« Array is illegal';
-    throws-like { [1, 2] «+» set(3, 4) }, X::AdHoc, 'Set «+» Array is illegal';
+    throws-like { set(1, 2) »+« set(3, 4) }, Exception,'Set »+« Set is illegal';
+    throws-like { set(1, 2) »+« [3, 4] }, Exception, 'Set »+« Array is illegal';
+    throws-like { set(1, 2) «+» [3, 4] }, Exception, 'Set «+» Array is illegal';
+    throws-like { [1, 2] »+« set(3, 4) }, Exception, 'Set »+« Array is illegal';
+    throws-like { [1, 2] «+» set(3, 4) }, Exception, 'Set «+» Array is illegal';
 }
 
 #?niecza skip "Hypers not yet Set compatible"

S02-types/subset.t

@@ -22,7 +22,7 @@ throws-like 'my Even $x = 3', X::TypeCheck::Assignment,
 
 # RT # 69518'
 #?niecza todo
-throws-like 'Even.new', X::AdHoc, 'Cannot instantiate a subtype';
+throws-like 'Even.new', Exception, 'Cannot instantiate a subtype';
 
 {
     ok 2 ~~ Even,  'Can smartmatch against subsets 1';
@@ -180,7 +180,7 @@ my $a = 1;
     }
     my &bar := producer();
     lives-ok { bar(2) }, 'where-constraint picks up the right lexical (+)';
-    throws-like 'bar(1)', X::AdHoc, 'where-constraint picks up the right lexical (-)';
+    throws-like 'bar(1)', Exception, 'where-constraint picks up the right lexical (-)';
 }
 
 {

S02-types/type.t

@@ -43,7 +43,7 @@ my Str $bar;
 #?niecza skip 'native types (noauto)'
 {
     eval-lives-ok('my int $alpha = 1',    'Has native type int');
-    throws-like 'my int $alpha = Nil', X::AdHoc, 'native int type cannot be undefined';
+    throws-like 'my int $alpha = Nil', Exception, 'native int type cannot be undefined';
     lives-ok({my Int $beta = Nil},      'object Int type can be undefined');
     eval-lives-ok('my num $alpha = 1e0',    'Has native type num');
     #?rakudo.jvm todo "nigh"

S03-operators/autoincrement.t

@@ -192,7 +192,7 @@ is(%z{0},           $base, '%z{0}');
 }
 
 # RT #63644
-throws-like 'my $a; $a++ ++;', X::AdHoc, 'parse error for "$a++ ++"';
+throws-like 'my $a; $a++ ++;', Exception, 'parse error for "$a++ ++"';
 
 # RT #99731
 {

S03-operators/misc.t

@@ -127,9 +127,9 @@ is (2 Z 3), @z, 'joining of single items';
 
 # comparison complains if either of its arguments is undefined - RT #93978
 {
-    throws-like {Int < 0}, X::AdHoc;
+    throws-like {Int < 0}, Exception;
     #?rakudo todo "RT #93978"
-    throws-like {"cat" gt Str}, X::AdHoc;
+    throws-like {"cat" gt Str}, Exception;
 }
 
 

S03-operators/subscript-vs-lt.t

@@ -16,7 +16,7 @@ plan 4;
 
 eval-lives-ok "1 <2", "infix less-than (<) requires whitespace before.";
 eval-lives-ok  "1 < 2" , "infix less-than (<) requires whitespace before.";
-throws-like "1< 2", X::AdHoc, "infix less-than (<) requires whitespace before, so this is a parse error.";
-throws-like "1<2", X::AdHoc, "infix less-than (<) requires whitespace before, so this is a parse error.";
+throws-like "1< 2", Exception, "infix less-than (<) requires whitespace before, so this is a parse error.";
+throws-like "1<2", Exception, "infix less-than (<) requires whitespace before, so this is a parse error.";
 
 # vim: ft=perl6