Just try to unlink, don't create a race

Author: lizmat

S10-packages/precompilation.t

@@ -9,7 +9,8 @@ my @precomp-paths;
 for <C A B> {
     my $path = "t/spec/packages/Example/{$_}.pm";
     my $precomp-path = $path ~ '.' ~ $*VM.precomp-ext;
-    unlink $precomp-path if $precomp-path.IO.e;
+    unlink $precomp-path; # don't care if failed
+
     ok CompUnit.new($path).precomp, "precomp Example::$_";
     ok $precomp-path.IO.e, "created $precomp-path";
     @precomp-paths.push: $precomp-path;
@@ -38,15 +39,16 @@ unlink $_ for @precomp-paths;
 
     my ($cu) = $cur.candidates('RT76456');
     ok $cu.precomp(:force), 'precompiled a parameterized role';
-    unlink $cu.precomp-path if $cu.precomp-path.IO.e;
+    unlink $cu.precomp-path; # don't care if failed
 }
 
 #RT #122447
 {
     # also a test of precompilation from the command line
     my $module-name = 'RT122447';
     my $output-path = "t/spec/packages/" ~ $module-name ~ '.pm.' ~ $*VM.precomp-ext;
-    unlink $output-path if $output-path.IO.e;
+    unlink $output-path; # don't care if failed
+
     is_run 'sub foo($bar) { Proxy.new( FETCH => sub (|) { }, STORE => sub (|) { } ) }', { err => '', out => '', status => 0 }, :compiler-args['--target', $*VM.precomp-target, '--output', $output-path ], 'precompile sub with params returning a proxy';
 
     is_run '0', { err => '', out => '', status => 0 }, :compiler-args['-I', 't/spec/packages', '-M', $module-name], 'precompile load - from the command line';
@@ -57,11 +59,13 @@ unlink $_ for @precomp-paths;
 {
     my $module-name = 'RT115240';
     my $output-path = "t/spec/packages/" ~ $module-name ~ '.pm.' ~ $*VM.precomp-ext;
-    unlink $output-path if $output-path.IO.e;
+    unlink $output-path; # don't care if failed
+
     is_run 'role Foo [ ] { }; role Bar does Foo[] { }', { err => '', out => '', status => 0 }, :compiler-args['--target', $*VM.precomp-target, '--output', $output-path ], "precomp curried role compose";
 
     is_run "use $module-name; class C does Bar { };", { err => '', out => '', status => 0 }, :compiler-args['-I', 't/spec/packages', '-M', $module-name], 'precompile load - from the command line';
-    unlink $output-path if $output-path.IO.e;
+
+    unlink $output-path; # don't care if failed
 }
 
 #RT #123276
@@ -72,7 +76,8 @@ unlink $_ for @precomp-paths;
         my $module-dir = join '/', split('::', $module-name);
         my $path = "t/spec/packages/{$module-dir}.pm";
         my $precomp-path = $path ~ '.' ~ $*VM.precomp-ext;
-        unlink $precomp-path if $precomp-path.IO.e;
+        unlink $precomp-path; # don't care if failed
+
         ok CompUnit.new($path).precomp(), "precomp Example::$_";
         @precomp-paths.push: $precomp-path;
     }
@@ -88,35 +93,38 @@ unlink $_ for @precomp-paths;
     #?rakudo.moar todo 'RT #123276'
     is_deeply @keys, [<foo>], 'RT123276';
 
-    unlink $_ for @precomp-paths;
+    unlink $_ for @precomp-paths;  # don't care if failed
 }
 
 #RT #124162
 {
     my $module-name = 'RT124162';
     my $output-path = "t/spec/packages/" ~ $module-name ~ '.pm.' ~ $*VM.precomp-ext;
-    unlink $output-path if $output-path.IO.e;
+    unlink $output-path; # don't care if failed
+
     is_run 'my @f = $(array[uint32].new(0,1)), $(array[uint32].new(3,4));',
         { err => '', out => '', status => 0 }, :compiler-args['--target', $*VM.precomp-target, '--output', $output-path ],
         "precomp of native array parameterization";
 
     is_run "use $module-name;",
         { err => '', out => '', status => 0 }, :compiler-args['-I', 't/spec/packages', '-M', $module-name],
         'precompile load - from the command line';
-    unlink $output-path if $output-path.IO.e;
+
+    unlink $output-path; # don't care if failed
 }
 
 {
     my $module-name-a = 'InternArrayA';
     my $output-path-a = "t/spec/packages/" ~ $module-name-a ~ '.pm.' ~ $*VM.precomp-ext;
-    unlink $output-path-a if $output-path-a.IO.e;
+    unlink $output-path-a; # don't care if failed
     is_run 'my constant VALUE = array[uint32].new; sub a() is export { VALUE }',
         { err => '', out => '', status => 0 }, :compiler-args['--target', $*VM.precomp-target, '--output', $output-path-a ],
         "precomp of native array parameterization intern test (a)";
 
     my $module-name-b = 'InternArrayB';
     my $output-path-b = "t/spec/packages/" ~ $module-name-b ~ '.pm.' ~ $*VM.precomp-ext;
-    unlink $output-path-b if $output-path-b.IO.e;
+
+    unlink $output-path-b; # don't care if failed
     is_run 'my constant VALUE = array[uint32].new; sub b() is export { VALUE }',
         { err => '', out => '', status => 0 }, :compiler-args['--target', $*VM.precomp-target, '--output', $output-path-b ],
         "precomp of native array parameterization intern test (b)";
@@ -126,5 +134,6 @@ unlink $_ for @precomp-paths;
     is_run "use $module-name-a; use $module-name-b; print a().WHAT =:= b().WHAT",
         { err => '', out => "True", status => 0 }, :compiler-args['-I', 't/spec/packages'],
         'precompile load of both and identity check passed';
-    unlink $_ if $_.IO.e for $output-path-a, $output-path-b;
+
+    unlink $_ for $output-path-a, $output-path-b; # don't care if failed
 }