re-wrote spurt tests, DRY

Author: dagurval

S32-io/spurt.t

@@ -1,79 +1,67 @@
 use v6;
 use Test;
-plan 12;
+#plan 22;
+plan *;
+
 # L<S32::IO/Functions/spurt>
 
 my $path = "tempfile-spurt-test";
 
-# Tests for:
-#    multi spurt (Str $filename,
-#                 Buf   $contents,
-#                 Bool :append = False,
-#                 Bool :$createonly = False)
-#
-# and
-#
-#    multi spurt (Str $filename,
-#                 Str   $contents,
-#                 Str  :$enc = $?ENC,
-#                 Bool :append = False,
-#                 Bool :$createonly = False,
-#?niecza skip "does not like Buf.new"
-{
-    my $buf = Buf.new(0xBE, 0xEF, 0xC0, 0xDE);
-
-    spurt($path, $buf); 
-    is slurp($path, :bin), $buf, "spurting Buf ok";
-
-    spurt $path, "24", :enc("ASCII");
-    is slurp($path), "24", "spurt to IO with enc";
-
-    spurt $path, $buf;
-    spurt $path, $buf, :append;
-    is slurp($path, :bin), ($buf ~ $buf), "spurting Buf with append";
-    unlink $path;
+# filename as str tests
+all-tests({ $path });
 
-    lives_ok { spurt $path, $buf, :createonly }, "createonly creates file";
-    ok $path.IO.e, "file was created";
-    dies_ok { spurt $path, :createonly }, "createonly fails if file exists";
-    unlink $path;
+# filename as IO tests
+#?rakudo skip "does not support IO::Handle"
+{
+    all-tests({ $path.IO });
 }
 
-# Tests for:
-#    multi spurt (IO $fh,
-#                 Str   $contents,
-#                 Str  :$enc = $?ENC,
-#                 Bool :append = False,
-#                 Bool :$createonly = False)
-# and
-#
-#    multi spurt (IO $fh,
-#                 Buf   $contents,
-#                 Bool :append = False,
-#                 Bool :$createonly = False)
-#?rakudo skip "No matching signature"
-{
-    spurt $path.IO, "42";
-    is slurp($path), "42", "spurt to IO";
+sub all-tests(Callable $handle) {
+    my $buf = Buf.new(0xBE, 0xEF, 0xC0, 0xDE);
+    my $txt = "42";
+
+    #?niecza skip ":bin option for slurp fails"
+    {
+        spurt $handle(), $buf; 
+        is slurp($path, :bin), $buf, "spurting Buf ok";
+    }
+    spurt $handle(), $txt;
+    is slurp($path), $txt, "spurting txt ok";
 
     #?niecza skip "Excess arguments to spurt, unused named enc"
     {
-        spurt $path.IO, "24", :enc("ASCII");
-        is slurp($path), "24", "spurt to IO with enc";
+        spurt $handle(), $txt, :enc("ASCII");
+        is slurp($path), $txt, "spurt with enc";
     }
-    
+
+    #?niecza skip "Excess arguments to spurt, unused named append"
+    {
+        spurt $handle(), $buf;
+        spurt $handle(), $buf, :append;
+        is slurp($path, :bin), ($buf ~ $buf), "spurting Buf with append";
+    }
+
     #?niecza skip "Excess arguments to spurt, unused named append"
     {
-        spurt $path.IO, "42";
-        spurt $path.IO, "24", :append;
-        is slurp($path), "4224", "spurt to IO with append";
+        spurt $handle(), $txt;
+        spurt $handle(), $txt, :append;
+        is slurp($path), ($txt ~ $txt), "spurting txt with append";
     }
+    
+    unlink $path;
+
+    #?niecza skip "Excess arguments to spurt, unused named createonly" 
+    lives_ok { spurt $handle(), $buf, :createonly }, "createonly creates file with Buf";
+    #?niecza todo ""
+    ok $path.IO.e, "file was created";
+    dies_ok { spurt $handle(), $txt, :createonly }, "createonly with Buf fails if file exists";
     unlink $path;
 
-    #?niecza 2 skip "Excess arguments to spurt, unused named createonly"
-    lives_ok { spurt $path.IO, "", :createonly }
+    #?niecza skip "Excess arguments to spurt, unused named createonly" 
+    lives_ok { spurt $handle(), $txt, :createonly }, "createonly with text creates file";
+    #?niecza todo ""
     ok $path.IO.e, "file was created";
-    dies_ok { spurt $path.IO, "", :createonly }
+    dies_ok { spurt $handle(), $txt, :createonly }, "createonly with text fails if file exists";
     unlink $path;
 }