Skip to content

Commit aa9255d

Browse files
committed
Some more unfudges and skip->todo changes
1 parent 198b4c6 commit aa9255d

File tree

6 files changed

+14
-12
lines changed

6 files changed

+14
-12
lines changed

S04-statements/do.t

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ eval_lives_ok 'my $i = 1; do { $i++ } if $i;',
8282
}
8383

8484
# L<S04/The do-once loop/"can take" "loop control statements">
85-
#?rakudo skip 'next() should also work on do blocks (?)'
85+
#?rakudo skip 'next without loop construct'
8686
{
8787
my $i;
8888
do {
@@ -93,7 +93,7 @@ eval_lives_ok 'my $i = 1; do { $i++ } if $i;',
9393
is $i, 1, "'next' works in 'do' block";
9494
}
9595

96-
#?rakudo 3 skip "labels"
96+
#?rakudo 3 skip "Undeclared name A"
9797
#?pugs 3 todo
9898
is eval('my $i; A: do { $i++; last A; $i-- }; $i'), 1,
9999
"'last' works with label";
@@ -102,7 +102,7 @@ is eval('my $i; A: do { $i++; next A; $i-- }; $i'), 1,
102102
is eval('my $i; A: do { $i++; redo A until $i == 5; $i-- }; $i'), 4,
103103
"'redo' works with label";
104104

105-
#?rakudo skip 'last not implemented'
105+
#?rakudo skip 'last without loop construct'
106106
{
107107
is eval('
108108
my $i;
@@ -118,7 +118,7 @@ is eval('my $i; A: do { $i++; redo A until $i == 5; $i-- }; $i'), 4,
118118
# IRC notes:
119119
# <agentzh> audreyt: btw, can i use redo in the do-once loop?
120120
# <audreyt> it can, and it will redo it
121-
#?rakudo skip 'redo not implemented'
121+
#?rakudo skip 'redo without loop construct'
122122
{
123123
is eval('
124124
my $i;

S04-statements/for.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -490,10 +490,10 @@ eval_dies_ok('for(0..5) { }','keyword needs at least one whitespace after it');
490490
}
491491

492492
# RT #64886
493-
#?rakudo skip "Nom doesn't feature lazily for looping over a range yet?"
493+
#?rakudo skip 'maybe bogus, for loops are not supposed to be lazy?'
494494
{
495495
my $a = 0;
496-
for (1..10000000000) {
496+
for 1..10000000000 {
497497
$a++;
498498
last;
499499
}

S05-capture/dot.t

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,23 +96,24 @@ grammar Russian { regex name { ivan } }
9696
ok("john" ~~ m/<.English::name> | <.French::name> | <.Russian::name>/, 'English name');
9797
is(~$/, "john", 'Match is john');
9898
ok($/ ne "jean", "Match isn't jean");
99-
#?rakudo 8 skip 'wrong tests? needs review'
99+
#?rakudo todo 'needs review'
100100
is(~$/<name>, "john", 'Name is john');
101101

102102
ok("jean" ~~ m/<.English::name> | <.French::name> | <.Russian::name>/, 'French name');
103103
is(~$/, "jean", 'Match is jean');
104+
#?rakudo todo 'needs review'
104105
is(~$/<name>, "jean", 'Name is jean');
105106

106107
ok("ivan" ~~ m/<.English::name> | <.French::name> | <.Russian::name>/, 'Russian name');
107108
is(~$/, "ivan", 'Match is ivan');
109+
#?rakudo todo 'needs review'
108110
is(~$/<name>, "ivan", 'Name is ivan');
109111

110112
my regex name { <.English::name> | <.French::name> | <.Russian::name> }
111113

112114
ok("john" ~~ m/<name>/, 'English metaname');
113115
is(~$/, "john", 'Metaname match is john');
114116
ok(~$/ ne "jean", "Metaname match isn't jean");
115-
#?rakudo todo 'unknown'
116117
is(~$/<name>, "john", 'Metaname is john');
117118

118119

S05-capture/match-object.t

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,12 @@ nok $/.Bool, 'failed match is False';
4040
is $/.Str, '', 'false match stringifies to empty string';
4141

4242
my $c;
43-
#?rakudo 3 skip 'Non-declarative sigil is missing its name at line 1, near "$\x{a2} }/\n"'
43+
#?rakudo skip 'Unsupported use of $¢ variable'
4444
#?pugs todo
4545
ok 'abc' ~~ /.{ $c =}/, 'current match state';
46+
#?rakudo todo 'Unsupported use of $¢ variable'
4647
#?pugs skip 'Cursor'
4748
is $c.WHAT.gist, Cursor.gist, 'got right type';
49+
#?rakudo skip "No such method pos for invocant of type Any"
4850
#?pugs skip 'Scalar.pos'
4951
ok defined($c.pos), '.pos';

S05-mass/properties-block.t

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -901,7 +901,6 @@ ok(!( "\x[D062]" ~~ m/^<:InLatin1Supplement>$/ ), q{Don't match unrelated <InLa
901901
ok("\x[D062]" ~~ m/^<:!InLatin1Supplement>$/, q{Match unrelated negated <InLatin1Supplement>} );
902902
#?pugs todo
903903
ok("\x[D062]" ~~ m/^<-:InLatin1Supplement>$/, q{Match unrelated inverted <InLatin1Supplement>} );
904-
#?rakudo skip "Malformed UTF-8 string"
905904
#?pugs todo
906905
ok("\x[D062]\x[0080]" ~~ m/<:InLatin1Supplement>/, q{Match unanchored <InLatin1Supplement>} );
907906

S05-mass/properties-derived.t

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,16 +74,15 @@ ok(!( "\x[3A18]" ~~ m/^<:Extender>$/ ), q{Don't match unrelated <Extender>} );
7474
ok("\x[3A18]" ~~ m/^<:!Extender>$/, q{Match unrelated negated <Extender>} );
7575
#?pugs todo
7676
ok("\x[3A18]" ~~ m/^<-:Extender>$/, q{Match unrelated inverted <Extender>} );
77-
#?rakudo skip "Malformed UTF-8 string"
7877
#?pugs todo
7978
ok("\x[3A18]\c[MIDDLE DOT]" ~~ m/<:Extender>/, q{Match unanchored <Extender>} );
8079

8180
# GraphemeLink
8281

8382

84-
#?rakudo 7 skip "isGraphemeLink"
8583
#?niecza todo
8684
#?pugs todo
85+
#?rakudo 3 todo "isGraphemeLink"
8786
ok("\c[COMBINING GRAPHEME JOINER]" ~~ m/^<:GraphemeLink>$/, q{Match <:GraphemeLink>} );
8887
ok(!( "\c[COMBINING GRAPHEME JOINER]" ~~ m/^<:!GraphemeLink>$/ ), q{Don't match negated <GraphemeLink>} );
8988
#?niecza todo
@@ -95,6 +94,7 @@ ok("\x[4989]" ~~ m/^<:!GraphemeLink>$/, q{Match unrelated negated <GraphemeLink
9594
ok("\x[4989]" ~~ m/^<-:GraphemeLink>$/, q{Match unrelated inverted <GraphemeLink>} );
9695
#?niecza todo
9796
#?pugs todo
97+
#?rakudo todo "isGraphemeLink"
9898
ok("\x[4989]\c[COMBINING GRAPHEME JOINER]" ~~ m/<:GraphemeLink>/, q{Match unanchored <GraphemeLink>} );
9999

100100
# HexDigit

0 commit comments

Comments
 (0)