Mapbox country code

[Nick59]

Hi !

I'm working with this great tool and i have a very small suggestions to do to make it better :)

I'm working with Mapbox API and i need the country short code which is not parsed in property list.

// Get country code
if (loc.context[j].short_code != 'undefined') {
       properties['countryShortCode'] = loc.context[j].short_code
}

I have a PR standing by if you are ok with this. ;)

Here is the full file with changes :

// src/geocoders/mapbox.js
import L from 'leaflet';
import { getJSON } from '../util';

export var Mapbox = L.Class.extend({
  options: {
    serviceUrl: 'https://api.mapbox.com/geocoding/v5/mapbox.places/',
    geocodingQueryParams: {},
    reverseQueryParams: {}
  },

  initialize: function(accessToken, options) {
    L.setOptions(this, options);
    this.options.geocodingQueryParams.access_token = accessToken;
    this.options.reverseQueryParams.access_token = accessToken;
  },

  geocode: function(query, cb, context) {
    var params = this.options.geocodingQueryParams;
    if (
      params.proximity !== undefined &&
      params.proximity.lat !== undefined &&
      params.proximity.lng !== undefined
    ) {
      params.proximity = params.proximity.lng + ',' + params.proximity.lat;
    }
    getJSON(this.options.serviceUrl + encodeURIComponent(query) + '.json', params, function(data) {
      var results = [],
        loc,
        latLng,
        latLngBounds;
      if (data.features && data.features.length) {
        for (var i = 0; i <= data.features.length - 1; i++) {
          loc = data.features[i];
          latLng = L.latLng(loc.center.reverse());
          if (loc.bbox) {
            latLngBounds = L.latLngBounds(
              L.latLng(loc.bbox.slice(0, 2).reverse()),
              L.latLng(loc.bbox.slice(2, 4).reverse())
            );
          } else {
            latLngBounds = L.latLngBounds(latLng, latLng);
          }

          var properties = {
            text: loc.text,
            address: loc.address
          };

          for (var j = 0; j < (loc.context || []).length; j++) {
            var id = loc.context[j].id.split('.')[0];
            properties[id] = loc.context[j].text;

            // Get country code
            if (loc.context[j].short_code != 'undefined') {
              properties['countryShortCode'] = loc.context[j].short_code
            }
          }

          results[i] = {
            name: loc.place_name,
            bbox: latLngBounds,
            center: latLng,
            properties: properties
          };
        }
      }

      cb.call(context, results);
    });
  },

  suggest: function(query, cb, context) {
    return this.geocode(query, cb, context);
  },

  reverse: function(location, scale, cb, context) {
    getJSON(
      this.options.serviceUrl +
        encodeURIComponent(location.lng) +
        ',' +
        encodeURIComponent(location.lat) +
        '.json',
      this.options.reverseQueryParams,
      function(data) {
        var results = [],
          loc,
          latLng,
          latLngBounds;
        if (data.features && data.features.length) {
          for (var i = 0; i <= data.features.length - 1; i++) {
            loc = data.features[i];
            latLng = L.latLng(loc.center.reverse());
            if (loc.bbox) {
              latLngBounds = L.latLngBounds(
                L.latLng(loc.bbox.slice(0, 2).reverse()),
                L.latLng(loc.bbox.slice(2, 4).reverse())
              );
            } else {
              latLngBounds = L.latLngBounds(latLng, latLng);
            }
            results[i] = {
              name: loc.place_name,
              bbox: latLngBounds,
              center: latLng
            };
          }
        }

        cb.call(context, results);
      }
    );
  }
});

export function mapbox(accessToken, options) {
  return new Mapbox(accessToken, options);
}

[simon04]

I have a PR standing by if you are ok with this. ;)

Yes, please. Reviewing a PR is easier than a manually crafted description of the changes.

[Nick59]

Hi, i can't push a new branch on your repo, that why i put it in plain text.

I need your authorization to push.

[simon04]

Please read and follow https://help.github.com/en/github/managing-files-in-a-repository/editing-files-in-another-users-repository or https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

[cdevassine]

Hello, what about geocodingQueryParams options ?
It's working for me for a France / Italy geocoder for example :
const geoCoder = new L.Control.Geocoder.Mapbox(token, { geocodingQueryParams: { country: "fr,it", language: "fr" } });

[Nick59]

Here is the PR : #278

@cdou this PR adds the ability to retrieve the shortcode of the place that the geocoder api returns. But yes, your solution works for having autocomplete in different language.

[Nick59]

PR Merged !

[Nick59]

Is it possible to tag the 1.12.2 so i can use it ?

Thanks.

[simon04]

Done: https://github.com/perliedman/leaflet-control-geocoder/releases/tag/1.13.0