Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --ci parameter to examples #259

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add --ci parameter to examples #259

merged 1 commit into from
Jul 30, 2024

Conversation

phh
Copy link

@phh phh commented Mar 13, 2024

Using --ci can save you if you accidently add a ->only() to one of your tests, which would prevent the whole testsuite from running. See Only plugin

I guess the idea behind --ci was also well. To run it during continuous integration :)

@owenvoke
Copy link
Member

owenvoke commented Mar 13, 2024

Personally, I think this makes sense. But 🤷🏻 Also, when reviewing this I was thinking it's kind of annoying to have to use --ci, so thought perhaps it could be auto-detected (I've opened a draft PR to suggest this: pestphp/pest#1114).

@phh
Copy link
Author

phh commented Mar 13, 2024

@owenvoke Thanks! I really agree with you. Setting --ci in CI by default seems like a very Laravel-y thing to do.

I personally would like it to automatically resolve that for me :D

@nunomaduro nunomaduro merged commit 5e14e52 into pestphp:master Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants