feat: auto-detect CI from environment #1114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-open the PR once this is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
I was looking at this PR on the docs earlier, and thought that it would be quite nice to add auto-detection for CI environments.
The majority of CI services (GitHub, GitLab, Travis, Bitbucket, CircleCI, etc.) provide a
CIenvironment variable that is set totrue, and this would basically allow us to auto-detect based on that.Note
My only thought is that this automatically disables the
Onlyplugin, which someone may want to use in CI.I'm not 100% sure about whether people do use it in CI much, but just thought I'd bring it up for discussion.
On the flip side, I do like being explicit, but having this might prevent excessive CI time usage when people forget to include
--ci. 🤷🏻