Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandas SettingWithCopyWarning #91

Closed
dweindl opened this issue Apr 2, 2019 · 4 comments
Closed

Pandas SettingWithCopyWarning #91

dweindl opened this issue Apr 2, 2019 · 4 comments
Assignees

Comments

@dweindl
Copy link
Member

dweindl commented Apr 2, 2019

Introduced in eae08e2.
@DantongWang Can you please fix that?

tests/test_visualization.py::test_generate_experimentId_no_empty
tests/test_visualization.py::test_generate_experiment_id_empty
  /home/dweindl/src/PEtab/petab/generate_experiment_id.py:80: SettingWithCopyWarning: 
  A value is trying to be set on a copy of a slice from a DataFrame
  
  See the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy
    measurement_data.experimentId[ind] = 'experiment_' + str(count)

tests/test_visualization.py::test_generate_experimentId_no_empty
tests/test_visualization.py::test_generate_experiment_id_empty
  /home/dweindl/.local/lib/python3.7/site-packages/pandas/core/indexing.py:190: SettingWithCopyWarning: 
  A value is trying to be set on a copy of a slice from a DataFrame
  
  See the caveats in the documentation: http://pandas.pydata.org/pandas-docs/stable/indexing.html#indexing-view-versus-copy
    self._setitem_with_indexer(indexer, value)

-- Docs: https://docs.pytest.org/en/latest/warnings.html
@DantongWang
Copy link
Contributor

Problem solved now. Should I merge it to 'develop' or 'master' branch?

@dweindl
Copy link
Member Author

dweindl commented Apr 8, 2019

Great. PR to develop please.

@dweindl
Copy link
Member Author

dweindl commented Apr 8, 2019

Closed by #97

@dweindl
Copy link
Member Author

dweindl commented May 3, 2019

Fixed in 0.0.0a14

@dweindl dweindl closed this as completed May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants