Fix Octave port

[petercorke]

Get RTB 10.x working with Octave

[petercorke]

Good work by @gedeschaines ultimately to be integrated into RTB.

Some notes on what's currently broken when running with Octave.

[gedeschaines]

I just updated the following files in ./Octave/rvctools:

common/plot2.m
robot/trplot.m
robot/trplot2.m
robot/utils/hgtransform.m

to address the problem using Octave 4.4.1 hgtransform on 2D and 3D plot lines in the trplot2 and trplot functions. The changes to these files are compatible with RTB v9.8 in MATLAB R2018b, but will break pose plotting in RTB v10. The updates do not address problem with hgtransform on text.

[petercorke]

Gary, I’m chatting with somebody about hgtransform issues at https://savannah.gnu.org/bugs/?50466 <https://savannah.gnu.org/bugs/?50466> peter

…

On 14 Dec 2018, at 4:48 pm, Gary E. Deschaines ***@***.***> wrote: I just updated the following files in ./Octave/rvctools <https://github.com/gedeschaines/robotics-toolbox-python/tree/update1/Octave>: common/plot2.m robot/trplot.m robot/trplot2.m robot/utils/hgtransform.m to address the problem using Octave 4.4.1 hgtransform on 2D and 3D plot lines in the trplot2 and trplot functions. The changes to these files are compatible with RTB v9.8 in MATLAB R2018b. The updates do not address problem with hgtransform on text. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALQUUvh_sER9GXlgmNLbcdy3K8zZmEfjks5u40m9gaJpZM4ZCMQW>.

[gedeschaines]

Peter, To put it succinctly, an hgtransform 'parent' property/value pair passed as arguments in line(), plot() and plot3() functions are interpreted by Octave's libinterp/corefnc/graphics routines as an hggroup 'parent' property/value pair; consequently not producing the desired results. I have sent you an email with a detailed explanation of the bug #50466 issue. Gary On Sat, Dec 15, 2018 at 7:50 PM Peter Corke <notifications@github.com> wrote:

…

Gary, I’m chatting with somebody about hgtransform issues at https://savannah.gnu.org/bugs/?50466 <https://savannah.gnu.org/bugs/?50466 > peter > On 14 Dec 2018, at 4:48 pm, Gary E. Deschaines ***@***.***> wrote: > > I just updated the following files in ./Octave/rvctools < https://github.com/gedeschaines/robotics-toolbox-python/tree/update1/Octave >: > > common/plot2.m > robot/trplot.m > robot/trplot2.m > robot/utils/hgtransform.m > > to address the problem using Octave 4.4.1 hgtransform on 2D and 3D plot lines in the trplot2 and trplot functions. The changes to these files are compatible with RTB v9.8 in MATLAB R2018b. The updates do not address problem with hgtransform on text. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub < #38 (comment)>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ALQUUvh_sER9GXlgmNLbcdy3K8zZmEfjks5u40m9gaJpZM4ZCMQW >. > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Adqf6-Kk-df-nlJi7P6LB9B_vhxkBytJks5u5ab7gaJpZM4ZCMQW> .

[petercorke]

Thanks for posting this on savannah, let’s see what Rik5 says.

…

On 18 Dec 2018, at 1:53 am, Gary E. Deschaines ***@***.***> wrote: Peter, To put it succinctly, an hgtransform 'parent' property/value pair passed as arguments in line(), plot() and plot3() functions are interpreted by Octave's libinterp/corefnc/graphics routines as an hggroup 'parent' property/value pair; consequently not producing the desired results. I have sent you an email with a detailed explanation of the bug #50466 issue. Gary On Sat, Dec 15, 2018 at 7:50 PM Peter Corke ***@***.***> wrote: > Gary, > > I’m chatting with somebody about hgtransform issues at > > https://savannah.gnu.org/bugs/?50466 <https://savannah.gnu.org/bugs/?50466 > > > > peter > > > On 14 Dec 2018, at 4:48 pm, Gary E. Deschaines ***@***.***> > wrote: > > > > I just updated the following files in ./Octave/rvctools < > https://github.com/gedeschaines/robotics-toolbox-python/tree/update1/Octave > >: > > > > common/plot2.m > > robot/trplot.m > > robot/trplot2.m > > robot/utils/hgtransform.m > > > > to address the problem using Octave 4.4.1 hgtransform on 2D and 3D plot > lines in the trplot2 and trplot functions. The changes to these files are > compatible with RTB v9.8 in MATLAB R2018b. The updates do not address > problem with hgtransform on text. > > > > — > > You are receiving this because you authored the thread. > > Reply to this email directly, view it on GitHub < > #38 (comment)>, > or mute the thread < > https://github.com/notifications/unsubscribe-auth/ALQUUvh_sER9GXlgmNLbcdy3K8zZmEfjks5u40m9gaJpZM4ZCMQW > >. > > > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#38 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/Adqf6-Kk-df-nlJi7P6LB9B_vhxkBytJks5u5ab7gaJpZM4ZCMQW> > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALQUUogW56DPgXYVzCAHA7EoOUsqM6dGks5u573jgaJpZM4ZCMQW>.