Fixing python2.7 and python3 compatibility issue #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original traceback:
```
Traceback (most recent call last):
File "/home/nicholas.carleson@usda-ars.orst.edu/opt/pico_galaxy/tools/protein_analysis/seq_analysis_utils.py", line 111, in fasta_iterator
raise StopIteration
StopIteration
```
|
Thanks for the stacktrace, I think the fix is even simpler - remove the |
Back to the original code, just remove the Stop
|
Hah, that also works! Very simple fix after all |
|
OK, this needs a version bump and pushing to the toolshed now... hang on. |
|
That's on the tool shed now as v0.2.13 - Python 3 fix for raising StopIteration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original traceback: