Allowing XLSXView to set openpyxl's read_only
property as True or False
#457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to allow XLSXView to set
read_only
as True or False; previously, default was True and caused an issue with LibreOffice files where the maximum number of rows read was 65536. Resolves #437 .Sample files to reproduce issue:
100krow-nofunc.xlsx - 100k rows, create with LibreOffice which causes only 65536 rows to be read in if
read_only = True
.Book-byMSExcelOnline.xlsx - Created with Microsoft Excel and does not have the 65536 row limitation on
read_only = True
.nosetest -v
andtox -e py27,py36
all passed after modifications.Unit test coverage has not decreased (see Coveralls)
Docstrings include notes for any changes to API or behaviour
Travis CI passes (unit tests run under Linux)
AppVeyor CI passes (unit tests run under Windows)
All changes documented in docs/changes.rst
Includes unit testsNew functions have docstrings with examples that can be run with doctestNew functions are included in API docs